[WebNN EP] Make sure optional input is provided #19686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some optional input is presented as empty string, we should not only check if the input size is correct, but also check if the optional input is not empty.
Contributor
Author
fdwr
reviewed
Mar 5, 2024
onnxruntime/core/providers/webnn/builders/impl/squeeze_unsqueeze_op_builder.cc
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline |
Contributor
|
/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed |
Contributor
|
/azp run ONNX Runtime Web CI Pipeline,Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
Azure Pipelines successfully started running 9 pipeline(s). |
Contributor
|
The failure says "CPUExecutionProvider", and so I don't think it is related to your change 🤔. https://github.com/microsoft/onnxruntime/pull/19686/checks?check_run_id=22329483029 |
Contributor
|
/azp run Big Models |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zz002
pushed a commit
to zz002/onnxruntime
that referenced
this pull request
Mar 7, 2024
Some optional input is presented as empty string, we should not only check if the input size is correct, but also check if the optional input is not empty. e.g. Pad node has empty optional input in sam-b-encoder.onnx model: <img width="514" alt="image" src="https://github.com/microsoft/onnxruntime/assets/3271201/cc3b06fe-46b9-4ee7-aca5-157bdf112856">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some optional input is presented as empty string, we should not only check if the input size is correct, but also check if the optional input is not empty.
e.g. Pad node has empty optional input in sam-b-encoder.onnx model:
