Cleanup some aspects of the Initializer class used by optimizers#2005
Merged
Conversation
…ific to Conv processing. Use references for arguments that can't be null.
kkaranasos
reviewed
Oct 8, 2019
kkaranasos
reviewed
Oct 8, 2019
Contributor
kkaranasos
left a comment
kkaranasos
left a comment
There was a problem hiding this comment.
Only comment is about the name of the namespace and whether it should be unified with the transformer_utils. Other than that, looks good.
Fix cmake file to include public headers
…ptimizerInitializerClass
kkaranasos
approved these changes
Oct 8, 2019
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
This commit adds optimum functions that are not exposed via optimum but are required for optimum pass cc: [@alexsu52](https://github.com/alexsu52) [@MaximProshin](https://github.com/MaximProshin) [@ynimmaga](https://github.com/ynimmaga)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Move check on data type outside of the Initializer class as it's specific to Conv processing.
Use references for arguments that can't be null.
Motivation and Context
Check on types within the Initializer class was confusing as the logic is unrelated.
Use references for consistency with the rest of the code.