Skip to content

Clean up ubuntu docker scripts#2103

Merged
snnn merged 1 commit intomasterfrom
snnn/ubuntu_docker
Oct 14, 2019
Merged

Clean up ubuntu docker scripts#2103
snnn merged 1 commit intomasterfrom
snnn/ubuntu_docker

Conversation

@snnn
Copy link
Contributor

@snnn snnn commented Oct 11, 2019

Description:

Clean up ubuntu docker scripts

Motivation and Context

  • Why is this change required? What problem does it solve?

The ubuntu 18.04 image is using packages from 16.04, it is not good.

  • If it fixes an open issue, please link to the issue here.

@snnn snnn requested a review from HectorSVC October 11, 2019 21:31
@snnn snnn requested a review from a team as a code owner October 11, 2019 21:31
@HectorSVC
Copy link
Contributor

done

why delete this file, it is used in c-api-artifacts-package-and-publish-steps-posix.yml for the C API package pipeline


Refers to: tools/ci_build/github/linux/copy_strip_binary.sh:14 in 177a099. [](commit_id = 177a099, deletion_comment = True)

@snnn
Copy link
Contributor Author

snnn commented Oct 12, 2019

done

why delete this file, it is used in c-api-artifacts-package-and-publish-steps-posix.yml for the C API package pipeline

Refers to: tools/ci_build/github/linux/copy_strip_binary.sh:14 in 177a099. [](commit_id = 177a099, deletion_comment = True)

I didn't delete it. I changed its file mode to executable.

Copy link
Contributor

@HectorSVC HectorSVC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@snnn snnn merged commit 5558b80 into master Oct 14, 2019
@snnn snnn deleted the snnn/ubuntu_docker branch October 14, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants