Skip to content

[ROCm] fix rocm-6.2 build issues#21993

Merged
tianleiwu merged 1 commit into
microsoft:mainfrom
hann-wang:fix/ck_rocm6.2
Sep 23, 2024
Merged

[ROCm] fix rocm-6.2 build issues#21993
tianleiwu merged 1 commit into
microsoft:mainfrom
hann-wang:fix/ck_rocm6.2

Conversation

@hann-wang
Copy link
Copy Markdown
Contributor

Composable Kernel build fails under ROCm 6.2.

This PR patches Composable Kernel the same way as ROCm/composable_kernel#1346

  • fix buffer resource to match "s" constraint
  • add missing memory clobber

@cloudhan
Copy link
Copy Markdown
Contributor

/azp run Linux ROCm CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@tianleiwu
Copy link
Copy Markdown
Contributor

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

@tianleiwu
Copy link
Copy Markdown
Contributor

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline

@tianleiwu
Copy link
Copy Markdown
Contributor

/azp run Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 5 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 8 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 10 pipeline(s).

@tianleiwu tianleiwu merged commit 7a782b7 into microsoft:main Sep 23, 2024
clang_tidy_check(${INSTANCE_NAME})
set(result 0)
--- ./include/ck/utility/amd_buffer_addressing.hpp 2024-09-05 10:12:33.343091000 +0800
+++ ./include/ck/utility/amd_buffer_addressing_new.hpp 2024-09-05 10:12:20.276686000 +0800
Copy link
Copy Markdown
Contributor

@tianleiwu tianleiwu Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hann-wang, is it expected that the filename is changed here? I think CK is still using the original filename:
https://github.com/ROCm/composable_kernel/blob/f16ebf82d42d49dc8905e5d6ac66eee8b25cd524/include/ck_tile/core.hpp#L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants