Skip to content

Pick changes from onnx/onnx#6010 to support EinSum shape inference #22376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fdwr merged 1 commit into from
Oct 10, 2024
Merged

Pick changes from onnx/onnx#6010 to support EinSum shape inference #22376

fdwr merged 1 commit into from
Oct 10, 2024

Conversation

@indygit
Copy link
Contributor

@indygit indygit commented Oct 10, 2024

Description

Pick up onnx/onnx#6010 to support EinSum shape inference

Motivation and Context

This change allows EinSum operator's output shape to be inferenced so that it can run on accelerators.

@fdwr
Copy link
Contributor

fdwr commented Oct 10, 2024 •
edited
Loading

FYI @peishenyan, @Honry.

This also unblocks: #19558

@fdwr fdwr requested review from fdwr and sumitsays October 10, 2024 01:25
fdwr
fdwr reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, else LGTM.

sumitsays
sumitsays approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@sumitsays sumitsays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this patch.

@tianleiwu
Copy link
Contributor

tianleiwu commented Oct 10, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Oct 10, 2024

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline

@tianleiwu
Copy link
Contributor

tianleiwu commented Oct 10, 2024

/azp run Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 10, 2024

Azure Pipelines successfully started running 5 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 10, 2024

Azure Pipelines successfully started running 8 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 10, 2024

Azure Pipelines successfully started running 10 pipeline(s).

fdwr
fdwr approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr
Copy link
Contributor

fdwr commented Oct 10, 2024

CI's good. Merging for Indy.

@fdwr fdwr merged commit b4fb32d into microsoft:main Oct 10, 2024
@Honry Honry mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fdwr fdwr fdwr approved these changes

@sumitsays sumitsays sumitsays approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@indygit @fdwr @tianleiwu @sumitsays