[CoreML] ML Program more ops (2/N) #22480

wejoncy · 2024-10-17T10:33:06Z

cast
argmax
gelu
cast
LayerNorm
GroupNorm
InstanceNorm

Description

Motivation and Context

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/test/providers/cpu/nn/group_norm_op_test.cc

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/test/contrib_ops/layer_norm_op_test.cc

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/test/contrib_ops/layer_norm_op_test.cc

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc

cast argmax gelu cast ln gn in

onnxruntime/core/providers/coreml/builders/model_builder.h

onnxruntime/core/providers/coreml/builders/op_builder_factory.cc

onnxruntime/core/providers/coreml/builders/impl/norm_ln_in_gn_op_builder.cc

onnxruntime/core/providers/coreml/builders/impl/argmax_op_builder.cc

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc

onnxruntime/test/providers/cpu/nn/group_norm_op_test.cc

onnxruntime/core/providers/coreml/builders/impl/activation_op_builder.cc

onnxruntime/core/providers/coreml/builders/impl/base_op_builder.cc

onnxruntime/core/providers/coreml/builders/impl/activation_op_builder.cc

onnxruntime/test/common/tensor_op_test_utils.h

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/core/providers/coreml/builders/impl/activation_op_builder.cc

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/test/contrib_ops/layer_norm_op_test.cc

-TEST(LayerNormTest, LayerNorm17_float) {
-  OpTester test("LayerNormalization", 17);
-  test.AddAttribute<float>("epsilon", 1e-05f);
+TYPED_TEST(LayerNormTest, LayerNorm17_opset) {


onnxruntime/test/providers/cpu/nn/instance_norm_op_test.cc

-                                   -1.65898662F, 0.27618144F, 0.64840618F, 0.734399F};
-  test.AddOutput<float>("Y", input_dims, expected_output);
-  test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kTensorrtExecutionProvider});
+TYPED_TEST(InstanceNormalizationOpTest, InstanceNorm) {


onnxruntime/test/providers/cpu/nn/instance_norm_op_test.cc

+    vector<int64_t> input_dims = {2, 3, 4};
+    test.AddInput<TypeParam>("input", input_dims, GetTypedArray<TypeParam>(input));
+
+    // vector<float> scale = {2.1F, 0.1F, 1.F};


onnxruntime/test/providers/cpu/nn/instance_norm_op_test.cc

+    vector<int64_t> scale_dims = {3};
+    test.AddInput<TypeParam>("scale", scale_dims, GetTypedArray<TypeParam>(scale), is_initializer);
+
+    // vector<float> B = {2.3F, 1.5F, 0.F};


onnxruntime/test/providers/cpu/nn/instance_norm_op_test.cc

-  test.AddOutput<float>("Y", input_dims, expected_output);
-
-  test.Run(OpTester::ExpectResult::kExpectSuccess, "", {kTensorrtExecutionProvider});
+TYPED_TEST(InstanceNormalizationOpTest, InstanceNormBatch1) {


onnxruntime/test/providers/cpu/reduction/reduction_ops_test.cc

+using ReductionOpTestTypes = ::testing::Types<float, MLFloat16>;
+TYPED_TEST_SUITE(ReductionOpTest, ReductionOpTestTypes);
+
+TYPED_TEST(ReductionOpTest, ArgMax) {


onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc

onnxruntime/core/providers/coreml/builders/model_builder.h

onnxruntime/core/providers/coreml/builders/impl/normalization_op_builder.cc

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/test/contrib_ops/layer_norm_op_test.cc

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc

…r.cc Co-authored-by: Scott McKay <skottmckay@gmail.com>

github-actions

You can commit the suggested changes from lintrunner.

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc

…r.cc Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

it's been resolved

wejoncy marked this pull request as ready for review October 17, 2024 10:33

wejoncy requested review from edgchen1 and skottmckay October 17, 2024 10:33

github-actions bot requested changes Oct 17, 2024

View reviewed changes

github-advanced-security bot found potential problems Oct 17, 2024

View reviewed changes

onnxruntime/test/providers/cpu/nn/group_norm_op_test.cc Fixed Show fixed Hide fixed

wejoncy force-pushed the jicwen/coremlops branch from 80119af to 662298d Compare October 18, 2024 03:32

github-actions bot requested changes Oct 19, 2024

View reviewed changes

onnxruntime/test/contrib_ops/layer_norm_op_test.cc Show resolved Hide resolved

github-actions bot requested changes Oct 19, 2024

View reviewed changes

onnxruntime/test/contrib_ops/layer_norm_op_test.cc Show resolved Hide resolved

github-actions bot requested changes Oct 19, 2024

View reviewed changes

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc Show resolved Hide resolved

wejoncy force-pushed the jicwen/coremlops branch from f8f351c to d66d70d Compare October 19, 2024 13:34

[CoreML] ML Program more ops

92c5677

cast argmax gelu cast ln gn in

wejoncy force-pushed the jicwen/coremlops branch from 8e9e614 to 92c5677 Compare October 21, 2024 03:04

wejoncy added 2 commits October 20, 2024 20:31

fix

18b5f80

fix

5d10f5b

skottmckay reviewed Oct 21, 2024

View reviewed changes

wejoncy added 3 commits October 21, 2024 02:38

address comments

c4210c3

fix

d969af5

add prelu

5da5c28

wejoncy changed the title ~~[CoreML] ML Program more ops~~ [CoreML] ML Program more ops (2/N) Oct 21, 2024

wejoncy added 2 commits October 21, 2024 04:34

add doc

d6c6951

delete unrelated comment

b699234

edgchen1 reviewed Oct 22, 2024

View reviewed changes

wejoncy and others added 3 commits October 21, 2024 21:07

handle special case for bn fp16

4ee495e

simply gelu check

28e16f6

Apply suggestions from code review

6c39114

Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>

github-actions bot requested changes Oct 22, 2024

View reviewed changes

onnxruntime/core/providers/coreml/builders/impl/activation_op_builder.cc Outdated Show resolved Hide resolved

wejoncy added 4 commits October 21, 2024 23:29

fix gelu

1f3a139

add macro for cis

dcd3818

layernorm test

836e5d4

remove debug code

c038f6b

github-actions bot requested changes Oct 24, 2024

View reviewed changes

onnxruntime/test/contrib_ops/layer_norm_op_test.cc Show resolved Hide resolved

format

6661f88

github-advanced-security bot found potential problems Oct 24, 2024

View reviewed changes

wejoncy added 2 commits October 27, 2024 20:44

simplify cast

ec575a7

fix

c80dfeb

skottmckay reviewed Oct 29, 2024

View reviewed changes

wejoncy added 3 commits October 29, 2024 11:27

address comments

f75d1eb

fix

1cbbd20

Merge branch 'main' into jicwen/coremlops

e60fef4

github-actions bot requested changes Oct 30, 2024

View reviewed changes

onnxruntime/test/contrib_ops/layer_norm_op_test.cc Show resolved Hide resolved

wejoncy added 3 commits October 30, 2024 03:17

format

60526a8

fix

4d904da

fix

3b2b7b8

skottmckay reviewed Oct 31, 2024

View reviewed changes

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc Outdated Show resolved Hide resolved

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc Outdated Show resolved Hide resolved

wejoncy and others added 3 commits October 31, 2024 14:15

Update onnxruntime/core/providers/coreml/builders/impl/cast_op_builde…

21ee7da

…r.cc Co-authored-by: Scott McKay <skottmckay@gmail.com>

cast or identity

972d346

fix

12ca0df

github-actions bot previously requested changes Oct 31, 2024

View reviewed changes

onnxruntime/core/providers/coreml/builders/impl/cast_op_builder.cc Outdated Show resolved Hide resolved

wejoncy and others added 2 commits October 31, 2024 15:50

Update onnxruntime/core/providers/coreml/builders/impl/cast_op_builde…

6c7b84f

…r.cc Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix

a0afa2a

skottmckay approved these changes Oct 31, 2024

View reviewed changes

wejoncy merged commit 9daf766 into main Nov 1, 2024

wejoncy deleted the jicwen/coremlops branch November 1, 2024 00:37

wejoncy mentioned this pull request Nov 4, 2024

[Mobile] Supporting more operators for NNAPI and CoreML #22346

Closed

yuygfgg mentioned this pull request Nov 5, 2024

Add support for MLprogram in ort_coreml AmusementClub/vs-mlrt#116

Merged

[CoreML] ML Program more ops (2/N) #22480

[CoreML] ML Program more ops (2/N) #22480

Uh oh!

Conversation

wejoncy commented Oct 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

wejoncy commented Oct 17, 2024 •

edited

Loading