[webgpu] Use workgroup_idx instead of workgroup_id.x#23696
Merged
guschmue merged 2 commits intomicrosoft:mainfrom Feb 14, 2025
Merged
[webgpu] Use workgroup_idx instead of workgroup_id.x#23696guschmue merged 2 commits intomicrosoft:mainfrom
guschmue merged 2 commits intomicrosoft:mainfrom
Conversation
We should always use workgroup_idx instead of workgroup_id.x in cause the dispatched workgroups are normalized.
Contributor
Author
|
@sushraja-msft @guschmue please take a look, thanks. |
Contributor
|
/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline |
Contributor
|
/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models |
Contributor
|
/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline, Win_TRT_Minimal_CUDA_Test_CI |
|
Azure Pipelines successfully started running 4 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
Azure Pipelines successfully started running 9 pipeline(s). |
sushraja-msft
approved these changes
Feb 14, 2025
guschmue
approved these changes
Feb 14, 2025
guschmue
pushed a commit
that referenced
this pull request
Mar 6, 2025
We should always use workgroup_idx instead of workgroup_id.x in cause the dispatched workgroups are normalized. When the input is large enough, the 1d workgroups will be normalized to 2d/3d and results incorrect result.
ashrit-ms
pushed a commit
that referenced
this pull request
Mar 17, 2025
We should always use workgroup_idx instead of workgroup_id.x in cause the dispatched workgroups are normalized. When the input is large enough, the 1d workgroups will be normalized to 2d/3d and results incorrect result.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should always use workgroup_idx instead of workgroup_id.x in cause the dispatched workgroups are normalized.
When the input is large enough, the 1d workgroups will be normalized to 2d/3d and results incorrect result.