Remove Unnecessary List Conversions in Input Validation #24331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the code by removing unnecessary
list()calls around.keys()in the_validate_inputmethod calls. The dict_keys views are already iterable and support membership testing, so converting them to a list and then searching within that list in the function is not needed. This change makes the code cleaner and provides a small optimization by avoiding the list conversion.Changes:
_validate_inputto passinput_feed.keys()andinput_dict_ort_values.keys()directly instead of wrapping them withlist().Motivation and Context
This cleans up the code and avoids an extra step that doesn’t add value. It’s a small improvement, not tied to fixing a specific issue, just making the code simpler and slightly more efficient.
No open issues are linked—this is just a minor cleanup.