update test case for test_convtranspose_autopad_same#24477
Merged
fs-eire merged 2 commits intomicrosoft:mainfrom Apr 22, 2025
Merged
update test case for test_convtranspose_autopad_same#24477fs-eire merged 2 commits intomicrosoft:mainfrom
fs-eire merged 2 commits intomicrosoft:mainfrom
Conversation
fs-eire
force-pushed
the
disable-failed-convtranspose-test-case
branch
from
53025ea to
f760b1a
Compare
…anspose-test-case
guschmue
approved these changes
Apr 22, 2025
intbf
pushed a commit
to intbf/onnxruntime
that referenced
this pull request
Apr 25, 2025
### Description <!-- Describe your changes. --> It looks like the test case `test_convtranspose_autopad_same` in ONNX opset14(v1.9) is generated incorrectly: onnx/onnx#3440 The problem is already fixed in opset15+(v1.10). So, this PR fixes 2 problems: - disable the test case for opset14 in onnxruntime-web tests ( still run the same test for opset15 and opset17 ) - re-enable the test case by removing if from "current_failing_tests" in onnxruntime\test\testdata\onnx_backend_test_series_filters.jsonc (which should have been done when upgrading to onnx v1.10) ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It looks like the test case
test_convtranspose_autopad_samein ONNX opset14(v1.9) is generated incorrectly: onnx/onnx#3440The problem is already fixed in opset15+(v1.10).
So, this PR fixes 2 problems:
Motivation and Context