Add libbacktrace in Linux Debug build#26257
Closed
tianleiwu wants to merge 3 commits into
Closed
Conversation
Contributor
|
abseil has this functionality. Or we may enable C++20 which has other benefits as well. |
Contributor
Author
You are right. Abseil uses libunwind and libbacktrace internally, so use abseil backtrace is a better solution. |
tianleiwu
added a commit
that referenced
this pull request
May 7, 2026
Replace glibc backtrace()/backtrace_symbols() with abseil's GetStackTrace()/Symbolize() in debug builds on Linux/POSIX. The previous implementation produced raw addresses requiring manual addr2line translation. The new implementation produces demangled function names (e.g. onnxruntime::InferenceSession::Run) directly in exception messages. No new dependency is introduced — absl::stacktrace and absl::symbolize are already linked via ABSEIL_LIBS. Windows stack traces (C++23 <stacktrace>) are unchanged. Closes #26257
tianleiwu
added a commit
that referenced
this pull request
May 7, 2026
Replace glibc backtrace()/backtrace_symbols() with abseil's GetStackTrace()/Symbolize() in debug builds on Linux/POSIX. The previous implementation produced raw addresses requiring manual addr2line translation. The new implementation produces demangled function names (e.g. onnxruntime::InferenceSession::Run) directly in exception messages. No new dependency is introduced — absl::stacktrace and absl::symbolize are already linked via ABSEIL_LIBS. Windows stack traces (C++23 <stacktrace>) are unchanged. Closes #26257
tianleiwu
added a commit
that referenced
this pull request
May 8, 2026
Replace glibc backtrace()/backtrace_symbols() with abseil's GetStackTrace()/Symbolize() in debug builds on Linux/POSIX. The previous implementation produced raw addresses requiring manual addr2line translation. The new implementation produces demangled function names (e.g. onnxruntime::InferenceSession::Run) directly in exception messages. No new dependency is introduced — absl::stacktrace and absl::symbolize are already linked via ABSEIL_LIBS. Windows stack traces (C++23 <stacktrace>) are unchanged. Closes #26257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show filename and line number in stack trace in Linux debug build.
I only tested CUDA build. Might need extra work (link libbacktrace) for CPU debug builds.