[test] refactor common test target settings #27013
Merged
+48
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors duplicated test target settings in the CMake build configuration by extracting common compile and link settings into reusable helper functions. The refactoring addresses code duplication between onnxruntime_test_all and onnxruntime_provider_test targets that occurred when the test suite was split.
Changes:
- Introduced two helper functions:
onnxruntime_apply_common_test_target_settingsfor compile flags andonnxruntime_apply_emscripten_test_link_settingsfor Emscripten link settings - Applied these functions to both
onnxruntime_test_allandonnxruntime_provider_testtargets - Removed duplicated configuration blocks that were previously copy-pasted between targets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fs-eire
changed the title
edgchen1
reviewed
Jan 21, 2026
edgchen1
reviewed
Jan 21, 2026
edgchen1
approved these changes
Jan 21, 2026
Contributor
edgchen1
left a comment
edgchen1
left a comment
There was a problem hiding this comment.
thanks for cleaning it up!
fs-eire
added a commit
to fs-eire/onnxruntime
that referenced
this pull request
Jan 22, 2026
### Description - factor duplicated test target settings into helper functions - reuse helpers for onnxruntime_test_all and onnxruntime_provider_test - keep target-specific settings intact ### Motivation and Context There are some duplicated codes in the onnxruntime_unittests. Originally there is only one unit test `onnxruntime_test_all` and later it is split into two: `onnxruntime_test_all` and `onnxruntime_provider_test`. Some lines for setting up build flags are simply copied. This causes potential risk for inconsistency in future. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
There are some duplicated codes in the onnxruntime_unittests. Originally there is only one unit test
onnxruntime_test_alland later it is split into two:onnxruntime_test_allandonnxruntime_provider_test. Some lines for setting up build flags are simply copied. This causes potential risk for inconsistency in future.