[BUILD] Fix Build Errors and Warnings in CUDA Providers #27276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariharans29
approved these changes
Feb 9, 2026
tianleiwu
added a commit
that referenced
this pull request
Feb 12, 2026
## Description User reported build error in #27269. This PR addresses several build issues and compilation warnings in the CUDA provider and associated contrib ops. These fixes ensure a clean build and improved compatibility with different CUDA versions (specifically CUDA 13.1) and compilers. ## Changes ### 1. Fix ShardedMoE Compilation Error - Resolved a "no matching function for call to CheckInputs" error in sharded_moe.cc - Updated the `moe_helper::CheckInputs` call to provide the required `zero_points` arguments (passing `nullptr`), aligning with the updated function signature. ### 2. Suppress CUDA 13.1 System Header Warnings - Added GCC/Clang diagnostic pragmas to suppress `-Wunused-parameter` warnings in `cuda_fp4.h`. - These warnings were causing build failures in environments where warnings are treated as errors. - Affected files: - onnxruntime/core/providers/cuda/cuda_common.h - onnxruntime/core/providers/cuda/cuda_type_conversion.h - onnxruntime/contrib_ops/cuda/llm/cutlass_type_conversion.h ### 3. Resolve Sign-Comparison Warnings - Fixed several `-Wsign-compare` warnings that were being treated as errors: - **Pad Op:** Changed loop variable type to `size_t` in onnxruntime/core/providers/cuda/tensor/pad.cc. - **Distributed Reshape:** Added explicit casts to `size_t` for `int64_t` comparisons in onnxruntime/contrib_ops/cuda/collective/distributed_reshape.cc. ## Verification - The build now completes successfully without errors or warnings using `--cmake_extra_defines onnxruntime_USE_NCCL=ON` - Builds tested with cuda 12.8, 13.0 and 13.1.1
tianleiwu
added a commit
that referenced
this pull request
Feb 13, 2026
This cherry-picks the following commits for the 1.24.2 release: - #27096 - #27077 - #26677 - #27238 - #27213 - #27256 - #27278 - #27275 - #27276 - #27216 - #27271 - #27299 - #27294 - #27266 - #27176 - #27126 - #27252 --------- Co-authored-by: Xiaofei Han <xiaofeihan@microsoft.com> Co-authored-by: Jiajia Qin <jiajiaqin@microsoft.com> Co-authored-by: Yulong Wang <7679871+fs-eire@users.noreply.github.com> Co-authored-by: qti-monumeen <monumeen@qti.qualcomm.com> Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com> Co-authored-by: Eric Crawford <eric.r.crawford@intel.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: guschmue <22941064+guschmue@users.noreply.github.com> Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: angelser <32746004+angelser@users.noreply.github.com> Co-authored-by: Angela Serrano Brummett <angelser@microsoft.com> Co-authored-by: Misha Chornyi <99709299+mc-nv@users.noreply.github.com> Co-authored-by: hariharans29 <9969784+hariharans29@users.noreply.github.com> Co-authored-by: eserscor <erscor@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Baiju Meswani <bmeswani@microsoft.com> Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com> Co-authored-by: Ti-Tai Wang <titaiwang@microsoft.com> Co-authored-by: bmehta001 <bmehta001@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User reported build error in #27269.
This PR addresses several build issues and compilation warnings in the CUDA provider and associated contrib ops. These fixes ensure a clean build and improved compatibility with different CUDA versions (specifically CUDA 13.1) and compilers.
Changes
1. Fix ShardedMoE Compilation Error
moe_helper::CheckInputscall to provide the requiredzero_pointsarguments (passingnullptr), aligning with the updated function signature.2. Suppress CUDA 13.1 System Header Warnings
-Wunused-parameterwarnings incuda_fp4.h.3. Resolve Sign-Comparison Warnings
-Wsign-comparewarnings that were being treated as errors:size_tin onnxruntime/core/providers/cuda/tensor/pad.cc.size_tforint64_tcomparisons in onnxruntime/contrib_ops/cuda/collective/distributed_reshape.cc.Verification
--cmake_extra_defines onnxruntime_USE_NCCL=ON