Fix CoreML reshape to support dynamic shapes#27324
Open
ingyukoh wants to merge 2 commits intomicrosoft:mainfrom
Open
Fix CoreML reshape to support dynamic shapes#27324ingyukoh wants to merge 2 commits intomicrosoft:mainfrom
ingyukoh wants to merge 2 commits intomicrosoft:mainfrom
Conversation
CoreML MIL supports -1 in shape dimensions and can infer at runtime. Change GetStaticShape to GetShape to allow dynamic input shapes, and only apply ReshapeHelper when the shape is fully static. Fixes microsoft#26328
Add a test model (Reshape with dynamic M dimension, shape [-1, 2048]) and a corresponding test case in dynamic_input_test.cc to verify the CoreML EP handles reshape operations with dynamic input shapes.
ingyukoh
force-pushed
the
fix-coreml-reshape
branch
from
47401bd to
221f693
Compare
Contributor
Author
|
@skottmckay Could you take a look at this? The fix changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreML MIL supports -1 in shape dimensions and can infer at runtime. This fix allows dynamic
input shapes for reshape operations.
Fixes #26328
Description
GetStaticShapetoGetShapeto allow dynamic dimensionsReshapeHelperwhen input shape is fully staticMotivation and Context
Users reshaping tensors to
[-1, N]were getting fallback to CPU with warnings aboutunsupported reshape operations on dynamic shapes.