Skip building custom_op_library if CUDA_MINIMAL is enabled #27520
Merged
Skip building custom_op_library if CUDA_MINIMAL is enabled #27520
Conversation
tianleiwu
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip building
custom_op_librarylibrary if CUDA_MINIMAL is enabledMotivation and Context
#27308 removes cudnn include for
custom_op_librarytarget in cmake if CUDA_MINIMAL is enabled.In fact, the
custom_op_librarytarget does not define theUSE_CUDA_MINIMALmacro (notarget_compile_definitions(custom_op_library PRIVATE -DUSE_CUDA_MINIMAL)in onnxruntime_unittests.cmake), so one of the files, i.e. cuda_context.h included in cuda_ops.cc still includes cudnn.h and the CI just got lucky to pass becasue cudnn.h is in --cuda_home. If building locally, it might fail to find cudnn.h.