Cleanup external data path validation#27539
Merged
adrianlizarraga merged 30 commits intomainfrom Mar 14, 2026
Merged
Conversation
yuslepukhin
reviewed
Mar 6, 2026
Member
yuslepukhin
left a comment
There was a problem hiding this comment.
I am having a hard time reviewing since my tools are not working.
See the tests that I introduced in my DRAFT PR in connection with my comment.
edgchen1
reviewed
Mar 7, 2026
…(can't escape root)
edgchen1
reviewed
Mar 11, 2026
Member
|
This is growing to be complicated. We will need a comprehensive documentation for this function detailing all what and why. |
… for weakly_canonical failure, rename variables
edgchen1
reviewed
Mar 12, 2026
edgchen1
previously approved these changes
Mar 13, 2026
edgchen1
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ValidateExternalData()function:(base_dir, model_dir)function parameters with justmodel_dir.base_dirwas always derived frommodel_dir.Statusinstead of throwing exceptions whenstd::filesystemfunctions fail.Graph::ConvertInitializersIntoOrtValues():ValidateExternalData()for external data paths that have already been validated.Motivation and Context