Java: avoid provider resource extraction when library already exists in onnxruntime.native.path#27668
Merged
skottmckay merged 4 commits intomicrosoft:mainfrom Mar 19, 2026
Conversation
Craigacp
reviewed
Mar 16, 2026
Contributor
Craigacp
left a comment
There was a problem hiding this comment.
The core change is fine, but the hooks and other tricks to make a test are not ideal. It would be better to remove those hooks and the test, the logic is simple enough.
skottmckay
approved these changes
Mar 17, 2026
Contributor
Author
|
Thanks for the review, @skottmckay |
Contributor
|
/azp run Windows ARM64 QNN CI Pipeline,Windows GPU Doc Gen CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Linux QNN CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Java native provider loading flow so that
extractProviderLibrarychecksonnxruntime.native.pathbefore attempting extraction from classpath resources.Previously, when a provider library was already present in
onnxruntime.native.path,the Java loader could still attempt
extractFromResources(...)first, and only fallback to the configured native path afterwards. This caused an unnecessary extraction
attempt even though the library was already available on disk.
This change updates the lookup order to:
onnxruntime.native.pathTests
Added a regression test covering the case where the requested provider library already
exists in
onnxruntime.native.path.The test verifies that:
extractProviderLibrary(...)returnstrueA small test-only hook was added to observe calls to
extractFromResources(...)so theregression can be validated directly and deterministically.
Issue
Fixes #27655