Add diagnostic context to ORT_ENFORCE bounds checks in TreeEnsemble operators#27678
Merged
xadupre merged 2 commits intoxadupre/tree110413from Mar 26, 2026
Merged
Add diagnostic context to ORT_ENFORCE bounds checks in TreeEnsemble operators#27678xadupre merged 2 commits intoxadupre/tree110413from
xadupre merged 2 commits intoxadupre/tree110413from
Conversation
…common.h Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on adding ORT_ENFORCE in TreeEnsemble operators PR
Add diagnostic context to ORT_ENFORCE bounds checks in TreeEnsemble operators
Mar 16, 2026
xadupre
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds informative error messages to the three
ORT_ENFORCEindex-bounds checks intree_ensemble_common.hthat validatetarget_class_ids,target_class_weights, andtarget_class_weights_as_tensoraccesses. Each message now surfaces the failing indexiand the container size, e.g.:Motivation and Context
The original bare
ORT_ENFORCE(i < ...)calls produced opaque failures with no indication of which attribute was malformed or what the actual index/size values were. This made it difficult to diagnose invalid or adversarial models. Addresses feedback from #27677.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.