Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two small but important web/JavaScript fixes: ensuring Closure Compiler doesn’t rename critical WebAssembly.Memory() option properties in the --pre-js injection, and correcting a cleanup list in the WASM artifact pull script.
Changes:
- Prevent Prettier from unquoting
WebAssembly.Memory()option keys so Closure Compiler won’t rename them (preserving correctshared: truebehavior). - Fix the artifact cleanup list to include
ort-wasm-simd-threaded.asyncify.wasminstead of a duplicated.mjsentry.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
onnxruntime/wasm/pre.js |
Adds prettier-ignore and keeps quoted option keys for WebAssembly.Memory() to avoid Closure Compiler property renaming. |
js/web/script/pull-prebuilt-wasm-artifacts.ts |
Fixes an incorrect duplicated filename so the script deletes the .wasm asyncify artifact as intended. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
guschmue
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2 small fixes to JavaScript code
The quote in the pre.js is important. closure compiler will skip minimizing the property names when they are quoted. Without the quote, the following code is generated:
property
sharedis rewritten intoBe, which is ignored byWebAssembly.Memory()andsharedis assumed to befalse(default value).