Skip to content

[CI] fix: use internal feed for NPM on ADO#28079

Merged
sanaa-hamel-microsoft merged 14 commits intomainfrom
dev/sanaahamel/ci-npm-authenticate
Apr 16, 2026
Merged

[CI] fix: use internal feed for NPM on ADO#28079
sanaa-hamel-microsoft merged 14 commits intomainfrom
dev/sanaahamel/ci-npm-authenticate

Conversation

@sanaa-hamel-microsoft
Copy link
Copy Markdown
Contributor

Description

Use internal NPM feed.

Motivation and Context

SDL requirements state that we consume everything in 1ES builds from one internal feed.

@sanaa-hamel-microsoft sanaa-hamel-microsoft force-pushed the dev/sanaahamel/ci-npm-authenticate branch from 4add56a to dbe4588 Compare April 15, 2026 23:00
guschmue
guschmue previously approved these changes Apr 16, 2026
vraspar
vraspar previously approved these changes Apr 16, 2026
@eserscor eserscor dismissed stale reviews from vraspar and guschmue via 0f98764 April 16, 2026 00:50
@sanaa-hamel-microsoft sanaa-hamel-microsoft enabled auto-merge (squash) April 16, 2026 20:29
@vraspar
Copy link
Copy Markdown
Contributor

vraspar commented Apr 16, 2026

Nit: The lint failure seems to be related — ShellCheck SC2086 is flagging unquoted $HOME in the new --volume args in build_nodejs_package.sh, build_tensorrt_c_api_package.sh, build_cuda_c_api_package.sh, and build_webgpu_plugin_package.sh. The other scripts in this PR already quote correctly. Quick fix: wrap those volume paths in double quotes, e.g. --volume "$HOME/.m2:/home/onnxruntimedev/.m2:ro".

@sanaa-hamel-microsoft sanaa-hamel-microsoft merged commit cafbd7c into main Apr 16, 2026
114 of 120 checks passed
@sanaa-hamel-microsoft sanaa-hamel-microsoft deleted the dev/sanaahamel/ci-npm-authenticate branch April 16, 2026 22:21
vraspar pushed a commit that referenced this pull request Apr 17, 2026
Use internal NPM feed.

SDL requirements state that we consume everything in 1ES builds from one
internal feed.

---------

Co-authored-by: Erik <erscor@microsoft.com>
sanaa-hamel-microsoft added a commit that referenced this pull request Apr 17, 2026
Use internal NPM feed.

SDL requirements state that we consume everything in 1ES builds from one
internal feed.

---------

Co-authored-by: Erik <erscor@microsoft.com>
vraspar added a commit that referenced this pull request Apr 17, 2026
This cherry-picks the following commits for the release:

| Commit ID | PR Number | Commit Title |
|-----------|-----------|-------------|
| 63dfc33 | #28034 | fix: idempotent feed setup |
| 58f99ea | #28064 | [C] fix: ADO CI spuriously failing format check
due to picking up NuGet.config |
| f9c83ae | #28084 | Fix the python pipeline |
| cafbd7c | #28079 | [CI] fix: use internal feed for NPM on ADO |

### Notes
- **#27945** was already in `rel-1.25.0` via meta cherry-pick PR #28035
(skipped).
- **#28079 conflict resolution**:
`tools/ci_build/github/linux/build_webgpu_plugin_package.sh` was removed
during cherry-pick. This file was created by PR #27841 (Add webgpu
plugin EP pipeline), which merged after the release branch cut and is
not part of this release. PR #28079 modified it on `main`, but since the
file never existed in `rel-1.25.0`, it was dropped.

---------

Co-authored-by: Sanaa Hamel <sanaahamel@microsoft.com>
Co-authored-by: eserscor <erscor@microsoft.com>
edgchen1 added a commit that referenced this pull request Apr 17, 2026
### Description
<!-- Describe your changes. -->

- Fix issue with custom .npmrc file not being found by
tools/ci_build/github/linux/build_webgpu_plugin_package.sh (follow up to
#28079)
- Set build-enabled parameters to true by default
- Configure nightly build in yaml
- Remove unnecessary NPM configuration in Windows build - now, it is
handled by templates/setup-build-tools.yml

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

Fix pipeline issue. Build all supported platforms nightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants