Skip to content

[WebNN] Rename roundingType to outputShapeRounding for pool2d ops#28172

Merged
guschmue merged 2 commits intomicrosoft:mainfrom
Honry:rename-roundingType
Apr 29, 2026
Merged

[WebNN] Rename roundingType to outputShapeRounding for pool2d ops#28172
guschmue merged 2 commits intomicrosoft:mainfrom
Honry:rename-roundingType

Conversation

@Honry
Copy link
Copy Markdown
Contributor

@Honry Honry commented Apr 22, 2026

Keep original roundingType name for a period of time to ensure backward compatibility.

Spec change: webmachinelearning/webnn#770

Keep original roundingType name for a period of time to ensure backward compatibility.

Spec change: webmachinelearning/webnn#770
@Honry
Copy link
Copy Markdown
Contributor Author

Honry commented Apr 22, 2026

@fdwr, @guschmue, PTAL, thanks!

@guschmue guschmue added the ep:WebNN WebNN execution provider label Apr 22, 2026
fdwr
fdwr previously approved these changes Apr 23, 2026
Copy link
Copy Markdown
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks Wanming.

Comment thread onnxruntime/core/providers/webnn/builders/impl/pool_op_builder.cc Outdated
Co-authored-by: Dwayne Robinson <fdwr@hotmail.com>
Copy link
Copy Markdown
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guschmue guschmue merged commit 8a77597 into microsoft:main Apr 29, 2026
83 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ep:WebNN WebNN execution provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants