Fixes for unicode path handling#28390
Open
jnagi-intel wants to merge 2 commits into
Open
Conversation
… handle UTF-8 Unicode paths on Windows
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates EP context output path handling to correctly interpret UTF-8 session config values as Unicode paths on Windows.
Changes:
- Add
ToPathString()conversion when constructingstd::filesystem::pathfromep_context_file_path. - Add explanatory comments about Windows UTF-8 vs ANSI code page path decoding.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0624e8b to
61e0f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
path::string()/ barestd::filesystem::path(string)withPathToUTF8String/ToPathStringin two places that handle user-suppliedpaths.
Motivation and Context
On Windows,
path::string()andstd::filesystem::path(std::string)use thesystem ANSI code page (CP_ACP). When a model or EPContext output file sits in a
directory with non-ASCII Unicode characters, this corrupts the path and causes:
ModelMetadefIdGenerator::GenerateId— throws during session initialization("No mapping for the Unicode character exists in the target multi-byte code page")
ModelGenOptions(EPContext options) — constructs a garbled path, failingEPContext file creation with
ENOENT