Address latent bug in LabelEncoder#28496
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the CUDA LabelEncoder to correctly pass tensor proto raw-data buffers into utils::UnpackTensor, improving correctness for attributes stored in raw format.
Changes:
- Passes
raw_datapointer and length intoutils::UnpackTensorwhen tensor protos contain raw data. - Applies the same unpacking fix in both scalar (
TryGetScalarTensorAttribute) and vector (GetAttrOrTensor) attribute paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tianleiwu
reviewed
May 13, 2026
tianleiwu
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines how tensor attributes are unpacked in the CUDA LabelEncoder implementation. The main improvement is ensuring that the raw data from tensor protos is explicitly passed to the
UnpackTensorutility, enhancing correctness and compatibility with various tensor data formats.Tensor attribute unpacking improvements:
TryGetScalarTensorAttributeandGetAttrOrTensorfunctions inlabel_encoder.cc, the code now checks if the tensor proto contains raw data and, if so, passes the correct raw data pointer and length toutils::UnpackTensor. This replaces the previous approach of always passingnullptrand0for these parameters. [1] [2]