Encapsulate global random seed in a function#28979
Merged
Merged
Conversation
Refactor global random seed management to use a function for better encapsulation.
kunal-vaishnavi
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor global random seed management to use a function for better encapsulation.
Description
Convert the file-scope static to a function-local static in
GetGlobalRandomSeed(), deferring initialization to first use. No API or behavioral change; all callers useGetRandomSeed()/SetRandomSeed()which remain identical.Motivation and Context
The global
g_random_seedwas initialized viastd::chrono::system_clock::now()at static construction time. When the ORT DLL is loaded dynamically (e.g., viaLoadLibraryExWin the fuzzer), this triggers an ASaninitialization-order-fiasco: ORT's_GLOBAL__sub_I_random_seed.cccallsstd::chrono::system_clock::now()before libc++'schrono.cppglobals (GetSystemTimeAsFileTimeFunc) are initialized.