Support override of free dimensions by name#3529
Closed
jeffbloo wants to merge 5 commits into
Closed
Conversation
jeffbloo
force-pushed
the
user/jeffbloo/FreeDimOverrideByName
branch
from
ad6259f to
a3a8a53
Compare
added 2 commits
April 15, 2020 16:25
…eDimOverrideByName merge master
pranavsharma
previously approved these changes
Apr 16, 2020
…eDimOverrideByName
jeffbloo
added a commit
that referenced
this pull request
Apr 22, 2020
This merges ORT Github master from to ADO DmlDev, in preparation with merging back to Github for ORT 1.3. This branch includes changes from the following PRs, which will now be closed: #3533 #3529 https://microsoft.visualstudio.com/WindowsAI/_git/onnxruntime/pullrequest/4569080 Related work items: #25935271
Contributor
Author
|
This change will be merged instead as part of the DML execution provider payload for ORT 1.3. |
This was referenced Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables sizes of free dimensions to be specified by name while a session is created, in addition to denotation.
The existing API which is based on denotation is preserved with binary compatibility (though renamed to AddFreeDimensionOverrideByDenotation) and is still used by Winml. A new API named AddFreeDimensionOverrideByName) is added.
The new API enables models which contain free width and height dimensions, for example, to be fully optimized during creation of the session.