Skip to content

Conversation

@natke
Copy link
Contributor

@natke natke commented Apr 23, 2020

Description: Generate compliant markdown table for operators and versions
 
Motivation and Context

  • Operator version doc is easier to parse
  • Table can be previewed in markdown renderers such as VSCode
  • Operator versions are ordered most recent to least recent to make changes more apparent
  • Type contraints are presented in one table cell, again to make it easier to parse

@natke natke requested a review from a team as a code owner April 23, 2020 16:32
@natke natke changed the title Fix markdown Render Operator documentation as compliant markdown Apr 23, 2020
</dl>


### <sub>experimental</sub> <a name="com.microsoft.Inverse"></a><a name="com.microsoft.inverse">**com.microsoft.Inverse**</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inverse is now an official ONNX op. I assume people should use that instead of an experimental contrib op, so do we need to add documentation here for it?

https://github.com/onnx/onnx/blob/master/docs/Operators.md#Inverse

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inverse should be removed from ONNX. At least that was the last decision. cc @codemzs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavsharma is correct, Inverse is being removed onnx/onnx#2747

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sync to latest. Inverse is removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skottmckay, @pranavsharma, @codezms It looks like Inverse is still being registered as a contrib operator the code (https://github.com/microsoft/onnxruntime/blob/master/onnxruntime/contrib_ops/cpu/inverse.cc#L24) and this is (AFAIK) how these docs get generated. So is the code correct? And the docs?

skottmckay
skottmckay previously approved these changes Apr 29, 2020
@snnn
Copy link
Contributor

snnn commented May 2, 2020

Hi @natke Could you please update your branch to the latest? I can't queue a build for you because some build definition file doesn't exist in your branch.

@snnn
Copy link
Contributor

snnn commented May 5, 2020

ping

@natke
Copy link
Contributor Author

natke commented May 6, 2020

Sure @snnn!

@snnn
Copy link
Contributor

snnn commented May 16, 2020

Sorry, I'm running late. Please resolve the conflict.

@natke
Copy link
Contributor Author

natke commented Jul 4, 2020

@snnn I've updated and removed the conflict

@stale
Copy link

stale bot commented Sep 2, 2020

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the stale issues that have not been addressed in a while; categorized by a bot label Sep 2, 2020
@stale stale bot removed the stale issues that have not been addressed in a while; categorized by a bot label Sep 2, 2020
@snnn snnn merged commit 8a03b6e into microsoft:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants