-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Render Operator documentation as compliant markdown #3658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| </dl> | ||
|
|
||
|
|
||
| ### <sub>experimental</sub> <a name="com.microsoft.Inverse"></a><a name="com.microsoft.inverse">**com.microsoft.Inverse**</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inverse is now an official ONNX op. I assume people should use that instead of an experimental contrib op, so do we need to add documentation here for it?
https://github.com/onnx/onnx/blob/master/docs/Operators.md#Inverse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inverse should be removed from ONNX. At least that was the last decision. cc @codemzs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavsharma is correct, Inverse is being removed onnx/onnx#2747
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sync to latest. Inverse is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skottmckay, @pranavsharma, @codezms It looks like Inverse is still being registered as a contrib operator the code (https://github.com/microsoft/onnxruntime/blob/master/onnxruntime/contrib_ops/cpu/inverse.cc#L24) and this is (AFAIK) how these docs get generated. So is the code correct? And the docs?
|
Hi @natke Could you please update your branch to the latest? I can't queue a build for you because some build definition file doesn't exist in your branch. |
|
ping |
|
Sure @snnn! |
|
Sorry, I'm running late. Please resolve the conflict. |
|
@snnn I've updated and removed the conflict |
|
This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details. |
Description: Generate compliant markdown table for operators and versions
Motivation and Context