Skip to content

[Node.js API] optimize prebuild #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fs-eire merged 4 commits into from
May 6, 2020
Merged

[Node.js API] optimize prebuild #3844

fs-eire merged 4 commits into from
May 6, 2020

Conversation

@fs-eire
Copy link
Contributor

@fs-eire fs-eire commented May 6, 2020

Description: This change optimized the prebuild behavior:

  • use different subfolders for multiple platform/arch for onnxruntime_binding.node
  • read version number from <ORT_root>/VERSION_NUMBER
  • use a custom script to replace package 'prebuild' (which does not support a dynamic binary path)

@fs-eire fs-eire requested a review from a team as a code owner May 6, 2020 18:07
@fs-eire fs-eire self-assigned this May 6, 2020
@fs-eire fs-eire requested a review from hariharans29 May 6, 2020 18:47
@fs-eire fs-eire merged commit 65bfece into master May 6, 2020
@fs-eire fs-eire deleted the fs-eire/nodejs-binding branch May 6, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hariharans29 hariharans29 hariharans29 approved these changes

Assignees

@fs-eire fs-eire

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fs-eire @hariharans29