[OpenVINO-EP] Add missing dependency libs in Dockerfile#4064
[OpenVINO-EP] Add missing dependency libs in Dockerfile#4064jywu-msft merged 4 commits intomicrosoft:masterfrom
Conversation
dockerfiles/Dockerfile.openvino
Outdated
| cp onnxruntime/docs/Privacy.md /code/Privacy.md && \ | ||
| cp onnxruntime/dockerfiles/LICENSE-IMAGE.txt /code/LICENSE-IMAGE.txt && \ | ||
| cp onnxruntime/ThirdPartyNotices.txt /code/ThirdPartyNotices.txt && \ | ||
| sed -i "s/sudo//" onnxruntime/dockerfiles/scripts/install_common_deps.sh &&\ |
There was a problem hiding this comment.
why is this needed?
is it just to get rid of the sudo at
if so, can we modify that script and remove the sudo when downloading cmake? i'm not sure why it's needed anyway.
There was a problem hiding this comment.
This is mainly needed to be able to validate container images behind company proxy servers and with conda python3 envs. There is a 'sudo pip install numpy' within the install_common_deps.sh, which we would like to use pip3 from the conda env. However, using sudo would cause it to use ubuntu 16.04's python2.7's pip instead. An alternative could be to replace sudo with 'sudo -E'.
There was a problem hiding this comment.
Where do you see sudo pip install numpy in install_common_deps.sh ? There's no sudo in the latest version on master.
There was a problem hiding this comment.
Ah.. my mistake.. i guess folks were having issues with line 22 (wget) behind proxy.
There was a problem hiding this comment.
yes, then we should get rid of the sudo in line 22. not sure why it's even there.
there isn't one for the wget in line 14.
There was a problem hiding this comment.
Sounds good. I have removed the sed replacement line to remove sudo from install_common_deps.sh
There was a problem hiding this comment.
Will you make that change to remove the sudo from the wget in install_common_deps.sh ?
otherwise you mentioned you were running into issues?
|
/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-mac-ci-pipeline |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline |
|
Azure Pipelines successfully started running 8 pipeline(s). |
|
will you also modify install_common_deps.sh to remove the sudo invocation of wget? |
'sudo' is not required, and hinders running script from within proxy environments. Removing it also makes lines consistent with each other (there are other wget lines without sudo).
|
'sudo' removed from install_common_deps.sh |
|
/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline |
|
Azure Pipelines successfully started running 8 pipeline(s). |
|
/azp run Windows GPU TensorRT CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-mac-ci-pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
4 participants
Description:
Motivation and Context