Skip to content

Remove signed/unsigned compiler warnings, add additional pipeline test case#4314

Merged
tlh20 merged 4 commits intomasterfrom
tiharr/dev-2
Jun 24, 2020
Merged

Remove signed/unsigned compiler warnings, add additional pipeline test case#4314
tlh20 merged 4 commits intomasterfrom
tiharr/dev-2

Conversation

@tlh20
Copy link
Copy Markdown
Contributor

@tlh20 tlh20 commented Jun 23, 2020

Description: Remove signed/unsigned compiler warnings, add additional pipeline test case

Motivation and Context: Minor updates I made while experimenting with distributed training:

  • Avoid compiler warnings seen with VS 2019 on signed/unsigned comparison
  • Extend DistributedRunContextTest with additional pipeline-size configuration case
  • Extend ORT_ENFORCE messages to report distributed size configuration

@tlh20 tlh20 added the training issues related to ONNX Runtime training; typically submitted using template label Jun 23, 2020
@tlh20 tlh20 requested review from wschin and xzhu1900 June 23, 2020 16:20
@tlh20 tlh20 requested a review from a team as a code owner June 23, 2020 16:20
Copy link
Copy Markdown
Contributor

@xzhu1900 xzhu1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tlh20 tlh20 merged commit 5c6a274 into master Jun 24, 2020
@tlh20 tlh20 deleted the tiharr/dev-2 branch June 24, 2020 10:36
rayankrish pushed a commit to rayankrish/onnxruntime that referenced this pull request Jun 24, 2020
…t case (microsoft#4314)

* Avoid signed/unsigned warning on loops

* Report sizes when distributed world configuration is inconsistent

* Add DistributedRunContextTest for pipeline stage configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

training issues related to ONNX Runtime training; typically submitted using template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants