Skip to content

Rename inner-scoped variable to avoid MSVC warning#4587

Merged
jywu-msft merged 1 commit into
microsoft:masterfrom
intel:manohar/msvc-warning-fix
Jul 29, 2020
Merged

Rename inner-scoped variable to avoid MSVC warning#4587
jywu-msft merged 1 commit into
microsoft:masterfrom
intel:manohar/msvc-warning-fix

Conversation

@smkarlap
Copy link
Copy Markdown
Contributor

Description: Renames inner scoped variable differently from outer scoped variable to avoid build failure due to compiler warning.

Motivation and Context

  • Certain version of MSVC compilers throw a warning if the inner-scoped name is same as the outer scoped name, which are treated as errors and cause build failure.

@smkarlap smkarlap requested a review from a team as a code owner July 22, 2020 19:53
@jywu-msft
Copy link
Copy Markdown
Member

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

@jywu-msft
Copy link
Copy Markdown
Member

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux OpenVINO CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 5 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 9 pipeline(s).

@smkarlap
Copy link
Copy Markdown
Contributor Author

This seems to pass all checks. can it be merged now?

@jywu-msft jywu-msft merged commit 623dd53 into microsoft:master Jul 29, 2020
@smkarlap smkarlap deleted the manohar/msvc-warning-fix branch July 29, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants