Implement QLinearMul in mlas#4593
Merged
Merged
Conversation
before build first draft. build ok? pass build Working qlmul test and sse2 drafting arm implementation. Fixed build for arm and pass linux arm32 test. Move common shared routine helpers to include file for add/mul correct some origin minor unused ptr inc, includes. Formatting. unroll more for sse2 qlmul erase empty line Another working version with speed test. SSE2 using int16 multiple for (qa-zeroa) * (qb-zerob). Move some function to header file. Remove speed test code from mlastest. Fix x86 build break on windows. Add QLinearMul operator based on mlas_qlinear_mul and test.
94af793 to
6089b2b
Compare
tracysh
suggested changes
Aug 21, 2020
the round to zero ?) Avoid test case on rounding for ties (n + 0.5).
tracysh
approved these changes
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator will be added later.