[Android NNAPI EP] change most of the exceptions to return Status#4701
Merged
Conversation
skottmckay
reviewed
Aug 4, 2020
skottmckay
reviewed
Aug 4, 2020
Contributor
|
Is there a compile option that checks for unused return values to make sure there's nowhere we're accidentally ignoring one? #Resolved |
skottmckay
reviewed
Aug 4, 2020
Contributor
Author
|
Seems the -Wunused-result option is by default on, seems it will not work for non-POD type, here is the gcc bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=38172 In reply to: 668400618 [](ancestors = 668400618) |
Contributor
Author
|
Actually I found we have ORT_MUST_USE_RESULT to check if the return Status is used, added it in the latest iter In reply to: 668783113 [](ancestors = 668783113,668400618) |
skottmckay
reviewed
Aug 5, 2020
skottmckay
reviewed
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: change most of the exceptions in NNAPI EP to return Status
Motivation and Context