Sahar/csharp support openvino by sfatimar · Pull Request #4703 · microsoft/onnxruntime

sfatimar · 2020-08-04T04:14:58Z

Description:
Changes to include csharp support for openvino
Openvino provider factory header is included as part of the nuget package to enable openvino ep for csharp build
Linux shared library included as part of nuget package through msbuild process for easy nuget packing

Motivation and Context

Enable building csharp api for openvino .
Csharp api are not supported directly on linux so we are documenting the workaround to include linux runtime package.

…with linux till we configure azure ci pipeline

Documentation includes openvino execution provider

update details to build csharp api for openvino execution provider .

…el/onnxruntime into sahar/csharp_support_openvino

updated for review comments

ghost · 2020-08-04T04:15:11Z

All CLA requirements met.

jywu-msft · 2020-08-04T04:22:23Z

@hariharans29 can you please help review? thanks.

tools/nuget/generate_nuspec_for_native_nuget.py

onnxruntime/core/providers/openvino/backends/vadm_backend.cc

change in native nuget spec python script for including linux runtime

…el/onnxruntime into sahar/csharp_support_openvino

tools/nuget/generate_nuspec_for_native_nuget.py

hariharans29 · 2020-08-04T20:17:13Z

tools/nuget/generate_nuspec_for_native_nuget.py

    # Process runtimes
+    # Process linux
+    if (args.linux_build != 'None'):
+        files_list.append('<file src=' + '"' + os.path.join(args.sources_path, args.linux_build) +


linux_build [](start = 84, length = 11)

I think we can just hard-code the shared library name - libonnxruntime.so. I think we have used onnxruntime.dll in a hard-coded fashion in a lot of places.

Unless there should be some functionality to copy the file from wherever it is to the correct location.

In reply to: 465305444 [](ancestors = 465305444)

csharp/OnnxRuntime.CSharp.proj

docs/execution_providers/OpenVINO-ExecutionProvider.md

skottmckay · 2020-08-04T21:47:33Z

docs/execution_providers/OpenVINO-ExecutionProvider.md

+On Windows Machine
+```
+cp libonnxruntime.so $PATH/onnxruntime/ 
+.\build.bat --config Debug --build --use_openvino $Device --build_csharp


What value should $PATH have? There are a few things it could be so a description would be better.

Not sure this is clear enough for a new user.

Where is libonnxruntime.so copied from? Assuming the build output directory from the Linux build, but there's no mention of where to find that like <ORT linux repo>/build/Linux/<config>.

Also feels a little hacky to just dump the linux .so file in the root directory of the ORT repo. Would be nicer to put it somewhere closer to where the C# build output would go, like <ORT Windows repo>\csharp\src\Microsoft.ML.OnnxRuntime\bin\<config>\linux.

tools/nuget/generate_nuspec_for_native_nuget.py

csharp/OnnxRuntime.CSharp.proj

docs/execution_providers/OpenVINO-ExecutionProvider.md

updated for review comments

jywu-msft · 2020-08-07T11:26:11Z

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

azure-pipelines · 2020-08-07T11:26:49Z

Azure Pipelines successfully started running 9 pipeline(s).

jywu-msft · 2020-08-07T11:27:23Z

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux OpenVINO CI Pipeline

azure-pipelines · 2020-08-07T11:27:48Z

Azure Pipelines successfully started running 5 pipeline(s).

jywu-msft · 2020-08-07T11:55:08Z

the python script modifications is failing PEP8 check.
see https://github.com/microsoft/onnxruntime/blob/master/docs/Coding_Conventions_and_Standards.md#python-code-style

yuslepukhin · 2020-08-10T18:24:56Z

onnxruntime/core/providers/openvino/openvino_provider_factory.cc

      device_ = "";
    } else {
-      device_ = device;
+      device_ = std::string(device);


std::string [](start = 16, length = 11)

Keep the assignment

modification to documentation

hariharans29 · 2020-08-13T19:15:34Z

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

hariharans29 · 2020-08-13T19:15:48Z

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux OpenVINO CI Pipeline

azure-pipelines · 2020-08-13T19:16:14Z

Azure Pipelines successfully started running 5 pipeline(s).

azure-pipelines · 2020-08-13T19:16:15Z

Azure Pipelines successfully started running 9 pipeline(s).

jywu-msft · 2020-08-14T05:41:03Z

tools/nuget/generate_nuspec_for_native_nuget.py

    parser.add_argument("--is_release_build", required=False, default=None, type=str,
                        help="Flag indicating if the build is a release build. Accepted values: true/false.")
+    parser.add_argument("--linux_build", required=False, default=False, type=bool,
+                        help="specify the libonnxruntime.so lib values")


the help string probably needs to be updated after the change to bool type.

jywu-msft · 2020-08-17T00:01:03Z

tools/nuget/generate_nuspec_for_native_nuget.py

    # Process runtimes
+    # Process linux
+    if (args.linux_build != 'None'):
+        files_list.append('<file src=' + '"' + os.path.join(args.sources_path, args.linux_build) +


args.linux_build is now a bool right?
so it should be os.path.join(args.sources_path, 'libonnxruntime.so') instead?

jywu-msft · 2020-08-17T00:01:30Z

tools/nuget/generate_nuspec_for_native_nuget.py


    # Process runtimes
+    # Process linux
+    if (args.linux_build != 'None'):


args.linux_build is now a bool, so this check for None needs to be changed?

This reverts commit 0a0ac70.

* Temp changes and include openvino to ensure nuget package is created with linux till we configure azure ci pipeline * string id change * native nuget indentation changes * documentation changes * Update Openvino_execution_provider.md Documentation includes openvino execution provider * Update OpenVino-ExecutionProvider.md update details to build csharp api for openvino execution provider . * vadm backend revert * Update Openvino-Execution-Provider.md updated for review comments * Update OpenVino-Execution-Provider.md * Update OpenVINO-ExecutionProvider.md * nuget package custome support for openvino change in native nuget spec python script for including linux runtime * change to make path to boolean flag * removed the tab * Update OpenVINO-ExecutionProvider.md updated for review comments * chnages to include pep8 warnings modification to documentation Co-authored-by: saharfraza <sfatima.3001@gmail.com> Co-authored-by: sfatimar <sahar.fatima@intel/com>

* Sahar/csharp support openvino (#4703) * Temp changes and include openvino to ensure nuget package is created with linux till we configure azure ci pipeline * string id change * native nuget indentation changes * documentation changes * Update Openvino_execution_provider.md Documentation includes openvino execution provider * Update OpenVino-ExecutionProvider.md update details to build csharp api for openvino execution provider . * vadm backend revert * Update Openvino-Execution-Provider.md updated for review comments * Update OpenVino-Execution-Provider.md * Update OpenVINO-ExecutionProvider.md * nuget package custome support for openvino change in native nuget spec python script for including linux runtime * change to make path to boolean flag * removed the tab * Update OpenVINO-ExecutionProvider.md updated for review comments * chnages to include pep8 warnings modification to documentation Co-authored-by: saharfraza <sfatima.3001@gmail.com> Co-authored-by: sfatimar <sahar.fatima@intel/com> * Changes to include csharp support for openvino * Fix flake error * Fix Co-authored-by: sfatimar <64512376+sfatimar@users.noreply.github.com> Co-authored-by: saharfraza <sfatima.3001@gmail.com> Co-authored-by: sfatimar <sahar.fatima@intel/com>

saharfraza and others added 11 commits July 28, 2020 11:54

Temp changes and include openvino to ensure nuget package is created …

f6dd0b4

…with linux till we configure azure ci pipeline

string id change

6be1212

native nuget indentation changes

12f448c

documentation changes

f4d395d

Update Openvino_execution_provider.md

66bf35c

Documentation includes openvino execution provider

Update OpenVino-ExecutionProvider.md

df37733

update details to build csharp api for openvino execution provider .

vadm backend revert

d7749f4

Merge branch 'sahar/csharp_support_openvino' of http://github.com/int…

b11702c

…el/onnxruntime into sahar/csharp_support_openvino

Update Openvino-Execution-Provider.md

5022ca2

updated for review comments

Update OpenVino-Execution-Provider.md

4fa75c6

Update OpenVINO-ExecutionProvider.md

d4566fb

sfatimar requested a review from a team as a code owner August 4, 2020 04:14

jywu-msft reviewed Aug 4, 2020

View reviewed changes

tools/nuget/generate_nuspec_for_native_nuget.py Outdated Show resolved Hide resolved

jywu-msft reviewed Aug 4, 2020

View reviewed changes

onnxruntime/core/providers/openvino/backends/vadm_backend.cc Outdated Show resolved Hide resolved

sfatimar added 2 commits August 4, 2020 17:13

nuget package custome support for openvino

f1bb2e1

change in native nuget spec python script for including linux runtime

Merge branch 'sahar/csharp_support_openvino' of http://github.com/int…

b440e0a

…el/onnxruntime into sahar/csharp_support_openvino

hariharans29 reviewed Aug 4, 2020

View reviewed changes

tools/nuget/generate_nuspec_for_native_nuget.py Outdated Show resolved Hide resolved

hariharans29 reviewed Aug 4, 2020

View reviewed changes

csharp/OnnxRuntime.CSharp.proj Outdated Show resolved Hide resolved

hariharans29 reviewed Aug 4, 2020

View reviewed changes

docs/execution_providers/OpenVINO-ExecutionProvider.md Show resolved Hide resolved

skottmckay reviewed Aug 4, 2020

View reviewed changes

tools/nuget/generate_nuspec_for_native_nuget.py Show resolved Hide resolved

skottmckay reviewed Aug 4, 2020

View reviewed changes

csharp/OnnxRuntime.CSharp.proj Show resolved Hide resolved

skottmckay reviewed Aug 4, 2020

View reviewed changes

docs/execution_providers/OpenVINO-ExecutionProvider.md Show resolved Hide resolved

sfatimar and others added 3 commits August 6, 2020 15:13

change to make path to boolean flag

f34b8df

removed the tab

6346181

Update OpenVINO-ExecutionProvider.md

9c1d82c

updated for review comments

yuslepukhin reviewed Aug 10, 2020

View reviewed changes

chnages to include pep8 warnings

12ed048

modification to documentation

jywu-msft reviewed Aug 14, 2020

View reviewed changes

jywu-msft reviewed Aug 17, 2020

View reviewed changes

jywu-msft approved these changes Aug 17, 2020

View reviewed changes

jywu-msft merged commit 0a0ac70 into microsoft:master Aug 17, 2020

jywu-msft added a commit that referenced this pull request Aug 17, 2020

Revert "Sahar/csharp support openvino (#4703)"

87642ce

This reverts commit 0a0ac70.

jywu-msft mentioned this pull request Aug 17, 2020

Revert "Sahar/csharp support openvino" #4822

Merged

snnn pushed a commit that referenced this pull request Aug 17, 2020

Revert "Sahar/csharp support openvino (#4703)"

94a6f50

This reverts commit 0a0ac70.

hariharans29 mentioned this pull request Aug 18, 2020

Sahar/csharp support openvino (refined) #4835

Merged

sfatimar deleted the sahar/csharp_support_openvino branch September 16, 2020 06:22

Conversation

sfatimar commented Aug 4, 2020

Uh oh!

ghost commented Aug 4, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jywu-msft commented Aug 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jywu-msft commented Aug 7, 2020

Uh oh!

azure-pipelines bot commented Aug 7, 2020

Uh oh!

jywu-msft commented Aug 7, 2020

Uh oh!

azure-pipelines bot commented Aug 7, 2020

Uh oh!

jywu-msft commented Aug 7, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hariharans29 commented Aug 13, 2020

Uh oh!

hariharans29 commented Aug 13, 2020

Uh oh!

azure-pipelines bot commented Aug 13, 2020

Uh oh!

azure-pipelines bot commented Aug 13, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ghost commented Aug 4, 2020 •

edited by ghost

Loading