Check status of element-wise op prepare functions. #4830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
previously approved these changes
Aug 17, 2020
thiagocrepaldi
previously approved these changes
Aug 17, 2020
SherlockNoMad
previously approved these changes
Aug 17, 2020
Contributor
SherlockNoMad
left a comment
SherlockNoMad
left a comment
There was a problem hiding this comment.
There are a few other places, which used Prepare() and prepare.BinaryElementwiseBroadcastPrepareHelper that didn't handle the error case.
e.g. activation_grad.cc, reduction_ops.cc and complex_mul.cc
Maybe do a global search for fix all all ?
…ryElementwise::Prepare().
edgchen1
dismissed stale reviews from SherlockNoMad, thiagocrepaldi, and snnn
via
cc3bfc6
thiagocrepaldi
previously approved these changes
Aug 17, 2020
…BroadcastPrepareHelper().
edgchen1
changed the title
snnn
approved these changes
Aug 17, 2020
thiagocrepaldi
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check status of BinaryElementwise::Prepare(), UnaryElementwise::Prepare(), and BinaryElementwisePreparation::BinaryElementwiseBroadcastPrepareHelper() and fail on error.
Motivation and Context
Encountered a segmentation fault later on because the result of a failed operation was ignored. Now, at least there is a more helpful error message.