Skip to content

Modify embedlayernorm fusion due to shape node merging#4967

Merged
wangyems merged 6 commits intomasterfrom
wangye/embedfix
Sep 8, 2020
Merged

Modify embedlayernorm fusion due to shape node merging#4967
wangyems merged 6 commits intomasterfrom
wangye/embedfix

Conversation

@wangyems
Copy link
Contributor

Fix embedlayernorm fusion for Bert and DistilBert due to "shape" integration
The initial structure(after L1 optimization) may contain multiple shape node after an unique input.
The current implementation makes sure that there is only one "shape" node which have multiple output

@wangyems wangyems requested a review from tianleiwu August 28, 2020 22:53
@wangyems wangyems requested a review from a team as a code owner August 28, 2020 22:53
@tianleiwu
Copy link
Contributor

Please add a test case.

@wangyems wangyems requested a review from tianleiwu September 3, 2020 18:51
@wangyems wangyems requested a review from tianleiwu September 4, 2020 04:11
tianleiwu
tianleiwu previously approved these changes Sep 4, 2020
Copy link
Contributor

@tianleiwu tianleiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangyems wangyems requested a review from tianleiwu September 8, 2020 18:26
@wangyems wangyems merged commit c239ff0 into master Sep 8, 2020
@wangyems wangyems deleted the wangye/embedfix branch September 8, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants