Move ort flatbuffers helper functions and value info r/w functions into separated lib#5276
Move ort flatbuffers helper functions and value info r/w functions into separated lib#5276guoyu-wang merged 14 commits intomasterfrom
Conversation
guoyu-wang
changed the title
guoyu-wang
changed the title
| #include <core/common/status.h> | ||
| #include <core/graph/basic_types.h> | ||
| #include <core/session/onnxruntime_c_api.h> | ||
|
|
There was a problem hiding this comment.
the C API is a really high level thing. why does a low level thing like this library have a dependency on it? #Resolved
There was a problem hiding this comment.
Oh, this include is only for the "ORT_MUST_USE_RESULT" which is defined in the c_api
In reply to: 494752637 [](ancestors = 494752637)
| endif() | ||
| target_include_directories(onnxruntime_flatbuffers PRIVATE ${ONNXRUNTIME_ROOT}) | ||
| add_dependencies(onnxruntime_flatbuffers ${onnxruntime_EXTERNAL_DEPENDENCIES}) | ||
| set_target_properties(onnxruntime_flatbuffers PROPERTIES FOLDER "ONNXRuntime") |
There was a problem hiding this comment.
this has a dependency on the graph library doesn't it given flatbuffers_utils.h includes a header from there? #Resolved
There was a problem hiding this comment.
may not need a link dependency but would be good to be more explicit about the dependency on the include path
In reply to: 494752823 [](ancestors = 494752823)
There was a problem hiding this comment.
Including core/graph/basic_types.h is only for the declaration of ONNX_NAMESPACE::ValueInfoProto, removed and add some forward decls
In reply to: 494759244 [](ancestors = 494759244,494752823)
|
|
||
| for (const auto argdef : grad_argdefs) { | ||
| for (const auto& argdef : grad_argdefs) { | ||
| ONNX_NAMESPACE::TensorProto_DataType elem_type = |
There was a problem hiding this comment.
This is a minor fix for a warning on latest Apple clang
|
@gwang-msft FYI this PR breaks master build. |
|
@xkszltl, yes, this will cause problems, not sure why CI did not catch this. |
|
I use cmake+ninja, maybe the generator is more sensitive than makefile. |
|
This is the build arg: https://github.com/xkszltl/Roaster/blob/14e68367389ad0b8fd809a48b4b70a76f183f89e/pkgs/ort.sh#L75-L135 |
|
There was another one, so it'll be great if it can be captured by CI: |
|
This #5306 should fix the issue |
3 participants
Description: Move ort flatbuffers helper functions and value info r/w functions into separated lib
Motivation and Context