Skip to content

Update the quantization script to support GEMM (transB==1)#5432

Merged
yufenglee merged 3 commits into
microsoft:masterfrom
flans39:gemm_quant
Nov 18, 2020
Merged

Update the quantization script to support GEMM (transB==1)#5432
yufenglee merged 3 commits into
microsoft:masterfrom
flans39:gemm_quant

Conversation

@flans39
Copy link
Copy Markdown
Contributor

@flans39 flans39 commented Oct 9, 2020

Description:

  • Update replace_gemm_with_matmul to support quantization of GEMM nodes whose transB equals 1.

Motivation and Context

@flans39 flans39 requested a review from a team as a code owner October 9, 2020 09:12
@ghost
Copy link
Copy Markdown

ghost commented Oct 9, 2020

CLA assistant check
All CLA requirements met.

@kit1980
Copy link
Copy Markdown
Contributor

kit1980 commented Oct 19, 2020

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 5 pipeline(s).

@kit1980 kit1980 added the quantization issues related to quantization label Oct 19, 2020
Copy link
Copy Markdown
Member

@yufenglee yufenglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Could you please add the handling of the case that B is not an initializer?

@yufenglee
Copy link
Copy Markdown
Member

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 5 pipeline(s).

@yufenglee
Copy link
Copy Markdown
Member

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,Linux OpenVINO CI Pipeline,Windows GPU TensorRT CI Pipeline, centos7_cpu, orttraining-linux-gpu-ci-pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 6 pipeline(s).

@yufenglee
Copy link
Copy Markdown
Member

/azp run Windows GPU CI Pipeline,Windows CPU CI Pipeline,MacOS NoContribops CI Pipeline,MacOS CI Pipeline,Linux CPU CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 4 pipeline(s).

@yufenglee
Copy link
Copy Markdown
Member

/azp run Linux CPU CI Pipeline

@flans39 flans39 requested a review from yufenglee October 29, 2020 11:53
@yufenglee yufenglee merged commit e8c0f5d into microsoft:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quantization issues related to quantization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants