Skip to content

Remove MKLML build config#5559

Merged
snnn merged 5 commits into
masterfrom
snnn/mklml
Oct 21, 2020
Merged

Remove MKLML build config#5559
snnn merged 5 commits into
masterfrom
snnn/mklml

Conversation

@snnn
Copy link
Copy Markdown
Contributor

@snnn snnn commented Oct 21, 2020

Description:

Remove MKLML build config

Motivation and Context

  • Why is this change required? What problem does it solve?

No one needs it anymore.

  • If it fixes an open issue, please link to the issue here.

Changming Sun added 2 commits October 20, 2020 16:57
@snnn snnn requested a review from a team as a code owner October 21, 2020 03:11
@pranavsharma
Copy link
Copy Markdown
Contributor

Should we still keep the build option and other infra around so that users can build from source if required? We just have to stop maintaining the packaging pipelines and pushing pkgs for this.

@snnn
Copy link
Copy Markdown
Contributor Author

snnn commented Oct 21, 2020

Should we still keep the build option and other infra around so that users can build from source if required? We just have to stop maintaining the packaging pipelines and pushing pkgs for this.

Yes, we can. But I worry it will be quickly out of maintain. For example, the #ifdefs for PrePack functions are subtle, they could be easily missed.

It's up to you. If you want to keep this change small, I can scope it down to just the yaml files.

@pranavsharma
Copy link
Copy Markdown
Contributor

Should we still keep the build option and other infra around so that users can build from source if required? We just have to stop maintaining the packaging pipelines and pushing pkgs for this.

Yes, we can. But I worry it will be quickly out of maintain. For example, the #ifdefs for PrePack functions are subtle, they could be easily missed.

It's up to you. If you want to keep this change small, I can scope it down to just the yaml files.

Ok, then let's remove it. Things going out-of-date and having to answer support questions is not good.

pranavsharma
pranavsharma previously approved these changes Oct 21, 2020
@snnn snnn merged commit 5802fe1 into master Oct 21, 2020
@snnn snnn deleted the snnn/mklml branch October 21, 2020 20:11
hariharans29 added a commit that referenced this pull request Nov 18, 2020
snnn pushed a commit that referenced this pull request Dec 25, 2020
Remove MKLML build config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants