Skip to content

Allow Upper case letters in RHS of einsum equations.#5569

Merged
hariharans29 merged 1 commit intomicrosoft:masterfrom
AndrewMcDowell:einsum_rhs_cased
Oct 26, 2020
Merged

Allow Upper case letters in RHS of einsum equations.#5569
hariharans29 merged 1 commit intomicrosoft:masterfrom
AndrewMcDowell:einsum_rhs_cased

Conversation

@AndrewMcDowell
Copy link
Contributor

Description: Update the Einsum operator to allow for upper case letters in the right hand side of the equation.

Motivation and Context
Einsum was updated here to allow for upper case letters in the left hand side of the equation, but the right hand side still required lower case letters only.

Addresses a missed case in the closed issue:
#4944

@AndrewMcDowell AndrewMcDowell requested a review from a team as a code owner October 22, 2020 14:59
@ghost
Copy link

ghost commented Oct 22, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@hariharans29 hariharans29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@hariharans29
Copy link
Member

/azp run Windows GPU CI Pipeline, WIndows GPU TensorRT CI Pipeline, centos7_cpu, centos7_cpu (linux_centos_ci Debug), centos7_cpu (linux_centos_ci Release), orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline

@hariharans29
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@hariharans29
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@hariharans29
Copy link
Member

/azp run all

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@hariharans29
Copy link
Member

/azp run Linux CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hariharans29
Copy link
Member

/azp run Linux CPU CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@hariharans29
Copy link
Member

/azp run Windows GPU CI Pipeline, WIndows GPU TensorRT CI Pipeline, centos7_cpu, centos7_cpu (linux_centos_ci Debug), centos7_cpu (linux_centos_ci Release), orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@hariharans29
Copy link
Member

/azp run Linux CPU CI Pipeline

@hariharans29
Copy link
Member

hariharans29 commented Oct 26, 2020

/azp run iOS CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hariharans29
Copy link
Member

/azp run Linux CPU Minimal Build E2E CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hariharans29
Copy link
Member

/azp run Linux CPU CI Pipeline

@hariharans29 hariharans29 merged commit b2da700 into microsoft:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants