MLAS: implement u8x8 GEMM for aarch32#5580
Merged
Merged
Conversation
Contributor
Author
|
/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline ,Linux OpenVINO CI Pipeline,MacOS CI Pipeline |
|
Azure Pipelines successfully started running 7 pipeline(s). |
yufenglee
reviewed
Oct 23, 2020
| #endif | ||
|
|
||
| #if defined(MLAS_TARGET_AMD64_IX86) || defined(MLAS_TARGET_ARM64) | ||
| #if defined(MLAS_TARGET_AMD64_IX86) || defined(MLAS_TARGET_ARM64) || (defined(MLAS_TARGET_ARM) && !defined(_MSC_VER)) |
Member
There was a problem hiding this comment.
_MSC_VER [](start = 107, length = 8)
Why _MSC_VER is excluded? It doesn't support certain instructions?
Contributor
Author
There was a problem hiding this comment.
There needs to be a different style of asm kernel ported to MSVC. This just gets in the Linux/Android piece.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Port the aarch64 kernel to aarch32 to light up the quantized GEMM path for Linux ARM32 builds. Tested on Raspberry Pi 3.