Conversation
tiagoshibata
previously approved these changes
Nov 6, 2020
tiagoshibata
previously approved these changes
Nov 6, 2020
snnn
previously approved these changes
Nov 6, 2020
tiagoshibata
approved these changes
Nov 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are new winml models that are being added into Onnxruntime test collateral. Many of these failed on x86, most of them couldn't load due to the large size of the model but some of them failed in session creation.
This change skips those tests before loading them to avoid throwing exception during LoadTests. I've added a TODO to file bugs for models that fail in session creation.
This change also fixes the adding of "testData" to the end of WINML_TEST_DATA_PATH environment variable.