[NNAPI] Split OPBuilder IsOpSupported into a separated class#5746
Merged
guoyu-wang merged 4 commits intomasterfrom Nov 10, 2020
Merged
[NNAPI] Split OPBuilder IsOpSupported into a separated class#5746guoyu-wang merged 4 commits intomasterfrom
guoyu-wang merged 4 commits intomasterfrom
Conversation
skottmckay
reviewed
Nov 10, 2020
skottmckay
reviewed
Nov 10, 2020
| bool IsOpSupportedImpl(const InitializerMap& initializers, const Node& node, const OPSupportCheckParams& params) override; | ||
| bool HasSupportedInputs(const Node& node) override; | ||
| int GetMinSupportedOpSet(const Node& node) override; | ||
| }; |
Contributor
There was a problem hiding this comment.
Can these be const? #Resolved
skottmckay
reviewed
Nov 10, 2020
onnxruntime/core/providers/nnapi/nnapi_builtin/builders/op_support_checker.cc
Show resolved
Hide resolved
skottmckay
reviewed
Nov 10, 2020
onnxruntime/core/providers/nnapi/nnapi_builtin/builders/op_support_checker.cc
Outdated
Show resolved
Hide resolved
skottmckay
reviewed
Nov 10, 2020
onnxruntime/core/providers/nnapi/nnapi_builtin/builders/op_support_checker.cc
Outdated
Show resolved
Hide resolved
skottmckay
reviewed
Nov 10, 2020
| uint32_t& index) ORT_MUST_USE_RESULT; | ||
|
|
||
| IOpBuilder* GetOpBuilder(const Node& node); | ||
| IOpSupportChecker* GetOPSupportChecker(const Node& node); |
Contributor
There was a problem hiding this comment.
GetOPSupportChecker [](start = 21, length = 19)
Missed one. :P GetOpSupportChecker. Can fix in a future PR. #Resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: [NNAPI] Split OPBuilder IsOpSupported into a separated class
Motivation and Context