Skip to content

Switch to unified DirectML 1.4.0 redistributable#5794

Merged
jstoecker merged 14 commits intomasterfrom
justoeck/dml_converged_redist
Nov 17, 2020
Merged

Switch to unified DirectML 1.4.0 redistributable#5794
jstoecker merged 14 commits intomasterfrom
justoeck/dml_converged_redist

Conversation

@jstoecker
Copy link
Copy Markdown
Contributor

@jstoecker jstoecker commented Nov 12, 2020

Transitions from the ORT-only DML NuGet (hosted on the onnxruntime_public feed) to the new unified DirectML NuGet (Microsoft.AI.DirectML) on nuget.org. In addition, the Microsoft.AI.MachineLearning (WinML) and Microsoft.ML.OnnxRuntime.DirectML packages now take a dependency on the Microsoft.AI.DirectML package. This means we can remove the extra copy of DML binaries in these packages since they will be installed by the DML package.

For reference, the file structure of the new package:

MICROSOFT.AI.DIRECTML.1.4.0
│   LICENSE-CODE.txt
│   LICENSE.txt
│   Microsoft.AI.DirectML.1.4.0.nupkg
│   README.md
│   ThirdPartyNotices.txt
│
├───bin
│   ├───x64-linux
│   │       libdirectml.so
│   │
│   ├───x64-win
│   │       DirectML.Debug.dll
│   │       DirectML.Debug.pdb
│   │       DirectML.dll
│   │       DirectML.lib
│   │       DirectML.pdb
│   │
│   └───x86-win
│           DirectML.Debug.dll
│           DirectML.Debug.pdb
│           DirectML.dll
│           DirectML.lib
│           DirectML.pdb
│
├───build
│       Microsoft.AI.DirectML.props
│       Microsoft.AI.DirectML.Rules.Project.xml
│       Microsoft.AI.DirectML.targets
│
└───include
        DirectML.h
        DirectMLConfig.h

@jstoecker jstoecker requested review from fdwr and smk2007 November 12, 2020 23:49
@jstoecker jstoecker requested a review from adtsai November 12, 2020 23:51
fdwr
fdwr previously approved these changes Nov 13, 2020
@jstoecker jstoecker marked this pull request as ready for review November 14, 2020 00:27
@jstoecker jstoecker requested a review from a team as a code owner November 14, 2020 00:27
@jstoecker jstoecker force-pushed the justoeck/dml_converged_redist branch from e590057 to 6e692f6 Compare November 16, 2020 23:25
@jstoecker jstoecker merged commit bd236ec into master Nov 17, 2020
@jstoecker jstoecker deleted the justoeck/dml_converged_redist branch November 17, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants