Skip to content

Filter initializers for GraphViewer with IndexedSubGraph #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guoyu-wang merged 7 commits into from
Nov 21, 2020
Merged

Filter initializers for GraphViewer with IndexedSubGraph #5884

guoyu-wang merged 7 commits into from
Nov 21, 2020

Conversation

@guoyu-wang
Copy link
Contributor

@guoyu-wang guoyu-wang commented Nov 20, 2020 •
edited
Loading

Description: Filter initializers for GraphViewer with IndexedSubGraph

Motivation and Context

  • Currently the initializers of GraphViewer with IndexedSubGraph is not filtered, it may include unnecessary initializers as part of the subgraph to EP , which may not be able to handle
  • Add filtered initializers if the GraphViewer has a filter
  • Modifed UT
  • GraphViewer::IsConstantInitializer is not updated with filtered initializers, since you still need to get the initializer name from the graph viewer

@guoyu-wang guoyu-wang requested a review from a team as a code owner November 20, 2020 21:37
skottmckay
skottmckay previously approved these changes Nov 20, 2020
View reviewed changes
@guoyu-wang
Copy link
Contributor Author

guoyu-wang commented Nov 21, 2020 •
edited
Loading

Will fix Android CI failure in a separated PR

Update:
The fix for Android CI failure is #5889

@guoyu-wang guoyu-wang merged commit cc6e8fb into master Nov 21, 2020
@guoyu-wang guoyu-wang deleted the gwang-msft/filtered_graph_viewer_initializer branch November 21, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skottmckay skottmckay skottmckay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guoyu-wang @skottmckay