Fix layer_norm.cc on x86#6556
Merged
Merged
Conversation
mrry
reviewed
Feb 4, 2021
mrry
reviewed
Feb 4, 2021
added 2 commits
February 8, 2021 13:28
cianmhayes
force-pushed
the
user/cianh/fix-32bit-layer-norm
branch
from
a2f985d to
ededac0
Compare
Contributor
Author
mrry
approved these changes
Feb 8, 2021
Contributor
mrry
left a comment
mrry
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Cian!
snnn
approved these changes
Feb 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Explicitly cast size parameters to int
Motivation and Context
Building with --enable_training or --enable_training_ops on x86 encounters build errors in layer_norm.cc because SizeToDimension and SizeFromDimension return int64_t, whereas the Eigen constructors and templates take int. This compiles fine in x64 builds, but in x86 builds all the uses of M or N produce an error like: