Relax atol When Comparing Forward Outputs#6969
Merged
thiagocrepaldi merged 1 commit intothiagofc/ortmodule-apifrom Mar 10, 2021
Merged
Relax atol When Comparing Forward Outputs#6969thiagocrepaldi merged 1 commit intothiagofc/ortmodule-apifrom
thiagocrepaldi merged 1 commit intothiagofc/ortmodule-apifrom
Conversation
Lafi7e
requested review from
BowenBao,
baijumeswani,
liqunfu,
spandantiwari and
thiagocrepaldi
as code owners
thiagocrepaldi
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax atol to 1e-06 when comparing forward outputs between PT and ORT, as the outputs contain quite some nearly-0 numbers. According to "absolute(a - b) <= (atol + rtol * absolute(b))", if the absolute(a-b) is larger than atol (which is possible), a very small b value will fail the check. For example, if atol=1e-08, if a=1.0000002, b=1.0000001, it will return True, but if a=0.0000002, b=0.0000001, absolute(a - b) is same here, but it will return False because b is too small.