Pass arguments to azure_scale_set_vm_mount_test_data for perf pipeline#7094
Merged
baijumeswani merged 1 commit intomasterfrom Mar 23, 2021
Merged
Pass arguments to azure_scale_set_vm_mount_test_data for perf pipeline#7094baijumeswani merged 1 commit intomasterfrom
baijumeswani merged 1 commit intomasterfrom
Conversation
liqunfu
approved these changes
Mar 22, 2021
thiagocrepaldi
approved these changes
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ORTModule branch was merged, changes in
azure_scale_set_vm_mount_test_data.shwere also merged. These changes required the file be invoked with some arguments.The
orttraining-linux-gpu-perf-test-ci-pipeline.ymlpipeline on master that was using this script without passing in the arguments. As a result, once the merge was complete, the pipeline started failing.Addressing this failing pipeline in the pull request by adding those arguments while invoking
azure_scale_set_vm_mount_test_data.shfile.