disable prepacking in training #7201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ke1337
reviewed
Mar 31, 2021
|
|
||
| if (disable_prepacking != "1") { | ||
| ORT_RETURN_IF_ERROR(PrepackConstantInitializedTensors(constant_initializers_use_count)); | ||
| } |
Contributor
There was a problem hiding this comment.
Seems disable prepacking is off by default? If I read the code correctly, the change here just removed disable prepacking option, instead of changing the default value?
Member
Author
There was a problem hiding this comment.
PrepackConstantInitializedTensors is the function to prepack the tensor
Contributor
There was a problem hiding this comment.
Maybe some comments why prepack is disabled for training here?
Contributor
|
Could we add a test case for CPU training with Gemm to make sure no regression in future? |
Member
Author
Agree. We need to add unit tests in the training branch to cover enough scenarios. |
guoyu-wang
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Prepacking uses the packed tensor for computation, which prevents the weight update on CPU.