Add a flag to allow for linking against shared system protobuf#7577
Add a flag to allow for linking against shared system protobuf#7577snnn merged 2 commits intomicrosoft:masterfrom
Conversation
In some environments you would like to link to the shared libprotobuf from the system. This is fine to use if you have full control over all protobuf users in your environment. This need for the existence of this option is already mentioned as a comment in CMakeLists.txt, this adds it now.
|
You can use the option: onnxruntime_PREFER_SYSTEM_LIB . |
|
I'm using |
|
Got it. How about this: instead of introducing a new build option, can you help me change: to a normal warning. Then please adjust the text message accordingly. |
|
/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux Nuphar CI Pipeline,Linux OpenVINO CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline |
|
/azp run Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,Windows WebAssembly CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule,orttraining-ortmodule-distributed |
|
Azure Pipelines successfully started running 9 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 9 pipeline(s). |
|
/azp run orttraining-amd-gpu-ci-pipeline |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thank you! The change will be in our next release, which will be published in a few weeks. Then you can update your conda package to take it. |
No need to patch that anymore. - microsoft/onnxruntime#7577 - microsoft/onnxruntime@203efef
2 participants
Description:
In some environments you would like to link to the shared libprotobuf from the system. This is fine to use if you have full control over all protobuf users in your environment.
This need for the existence of this option is already mentioned as a comment in CMakeLists.txt, this adds it now.
Describe your changes.
Motivation and Context
We have packaged
onnxruntimefor conda-forge. There we prefer shared linkage and have a good control (and automation) to link everything to the same protobuf library and also rebuild everything on a protobuf update. This adds an option toCMakeLists.txtto allow us to use the shared library without us patching the source.