Skip to content

Enable bitcode for iOS by default#7640

Merged
guoyu-wang merged 1 commit intomasterfrom
gwang-msft/ios_bitcode
May 11, 2021
Merged

Enable bitcode for iOS by default#7640
guoyu-wang merged 1 commit intomasterfrom
gwang-msft/ios_bitcode

Conversation

@guoyu-wang
Copy link
Contributor

@guoyu-wang guoyu-wang commented May 11, 2021

Description: Enable bitcode for iOS by default

Motivation and Context

  • Bitocde is by default enabled for xocde iOS projects, (TFLite cocoapod package has bitcode enabled by default)
  • For now if bticode is not enabled, ort is compiled with -fembed-bitcode-marker, disable bitcode completely when bitcode is not enabled

@guoyu-wang guoyu-wang requested a review from a team as a code owner May 11, 2021 00:30
Copy link
Contributor

@skottmckay skottmckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@guoyu-wang guoyu-wang merged commit 69d1db8 into master May 11, 2021
@guoyu-wang guoyu-wang deleted the gwang-msft/ios_bitcode branch May 11, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants