Add Apple log sink.#7820
Merged
Merged
Conversation
skottmckay
reviewed
May 25, 2021
guoyu-wang
reviewed
May 25, 2021
| } else { | ||
| #ifdef __ANDROID__ | ||
| ISink* sink = new AndroidLogSink(); | ||
| #if defined(__ANDROID__) |
Contributor
There was a problem hiding this comment.
Do we want to add an separated function to host all these #ifdef's?
#Resolved
guoyu-wang
reviewed
May 25, 2021
|
|
||
| - (void)dealloc { | ||
| [self cleanup]; | ||
| [super dealloc]; |
Contributor
There was a problem hiding this comment.
You don't need this if ARC is enabled
https://clang.llvm.org/docs/AutomaticReferenceCounting.html#dealloc
I guess we hit some pipeline failure on this
/Users/runner/work/1/s/onnxruntime/core/providers/coreml/model/model.mm:170:10: error: ARC forbids explicit message send of 'dealloc' #Resolved
Contributor
Author
There was a problem hiding this comment.
-fobjc-arc is somehow not going through in my tests, seeing a different error as a result:
error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
trying to figure that out.
edgchen1
added a commit
that referenced
this pull request
Jun 12, 2021
Add a log sink for Apple platforms. This version uses NSLog().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a log sink for Apple platforms. This version uses NSLog().
Motivation and Context
Enable logging with the Apple logging system.